Well I would say a GOOD SMITH is an artist, they transform guns.
The can work metal so that it looks like it was never touched. I believe there is a diference between a Gunsmith and someone who works on guns. Someone who works on guns can make them mechanicaly function, but will leave evidence of there work. A gunsmith is more like an artist they modify guns and make them mechanicaly function, but as mentioned leave no evidence of their work.
I would say a gunsmith is a jack of all trades, a machinist, a carpenter, a mechanic, and a few other things wrapped up in one. I belive like a doctor there is specilist gunsmiths like barrel makers, stock makers and engravers.
I would say a gunsmith should limmit there work to only a couple of gun brands, such as a smith that only works on 1911's and ar15's and nothing else, or a smith that only works on S&W revolvers, and Remington rifles. I belive first that the cost of tooling and constant changes effects the end product.
I belive a smith should charge by the job and not by the hour, this is what car mechanics do and other profesions as well.
On mark up the smith needs to be competive with other smiths. His mark up should also be a refection of his work, if it is very good people will pay, and the smith will have long waiting list to get in.
Serices my favorite smiths offer, well I mainly deal with Savage rifles and 1911's so I look for timming and truing, aftermarket triggers, aftermarket stocks, and other things I can not do my self, for I dont have the tooling or knowhow.